Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1459 #1478

Merged
merged 2 commits into from
Feb 27, 2024
Merged

#1459 #1478

merged 2 commits into from
Feb 27, 2024

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Feb 26, 2024

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #1459

Copy link

sonarcloud bot commented Feb 26, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 95.14%. Comparing base (88af380) to head (2e7cbfb).

❗ Current head 2e7cbfb differs from pull request most recent head ab885fa. Consider uploading reports for the commit ab885fa to get more accurate results

Files Patch % Lines
...eryx/components/logical_planner/logical_planner.py 81.25% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
- Coverage   95.16%   95.14%   -0.03%     
==========================================
  Files         206      206              
  Lines        9440     9473      +33     
==========================================
+ Hits         8984     9013      +29     
- Misses        456      460       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joocer joocer merged commit 2536938 into main Feb 27, 2024
1 of 2 checks passed
@joocer joocer deleted the #1459 branch February 27, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ reinstate EXECUTE functionality
2 participants