Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1517 #1518

Merged
merged 4 commits into from
Mar 14, 2024
Merged

#1517 #1518

merged 4 commits into from
Mar 14, 2024

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Mar 14, 2024

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #<issue_number_goes_here>

Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (19a0aa0) to head (a846a90).

❗ Current head a846a90 differs from pull request most recent head ecd9986. Consider uploading reports for the commit ecd9986 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   94.97%   94.96%   -0.01%     
==========================================
  Files         211      211              
  Lines        9651     9653       +2     
==========================================
+ Hits         9166     9167       +1     
- Misses        485      486       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joocer joocer merged commit 05ed3f5 into main Mar 14, 2024
1 of 2 checks passed
@joocer joocer deleted the #1517 branch March 14, 2024 10:32
@joocer joocer restored the #1517 branch March 14, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants