Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE/#43 #168

Merged
merged 5 commits into from
Jun 8, 2022
Merged

FEATURE/#43 #168

merged 5 commits into from
Jun 8, 2022

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Jun 8, 2022

No description provided.

@ghost
Copy link

ghost commented Jun 8, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #168 (f5d4238) into main (6814a15) will decrease coverage by 1.18%.
The diff coverage is 79.52%.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   91.47%   90.28%   -1.19%     
==========================================
  Files          75       75              
  Lines        2767     2831      +64     
==========================================
+ Hits         2531     2556      +25     
- Misses        236      275      +39     
Impacted Files Coverage Δ
opteryx/utils/dates.py 80.82% <ø> (-0.26%) ⬇️
...engine/planner/operations/function_dataset_node.py 42.50% <42.50%> (ø)
...teryx/engine/planner/operations/evaluation_node.py 94.00% <66.66%> (-1.75%) ⬇️
...pteryx/engine/planner/operations/aggregate_node.py 90.60% <71.42%> (-0.50%) ⬇️
opteryx/engine/planner/operations/distinct_node.py 87.50% <71.42%> (-2.50%) ⬇️
...pteryx/engine/planner/operations/base_plan_node.py 92.85% <80.00%> (+1.94%) ⬆️
opteryx/engine/planner/operations/offset_node.py 88.88% <80.00%> (-2.03%) ⬇️
...pteryx/engine/planner/operations/selection_node.py 89.81% <80.00%> (-0.67%) ⬇️
opteryx/engine/planner/operations/sort_node.py 93.18% <80.00%> (-1.82%) ⬇️
...teryx/engine/planner/operations/projection_node.py 93.65% <83.33%> (-1.35%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6814a15...f5d4238. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
29.0% 29.0% Duplication

@joocer joocer merged commit 35c4d3c into main Jun 8, 2022
@joocer joocer deleted the FEATURE/#43.1 branch June 8, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant