Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/#178 #187

Merged
merged 2 commits into from
Jun 11, 2022
Merged

Fix/#178 #187

merged 2 commits into from
Jun 11, 2022

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Jun 11, 2022

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghost
Copy link

ghost commented Jun 11, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #187 (ca3959c) into main (1e881d2) will decrease coverage by 0.04%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   90.22%   90.17%   -0.05%     
==========================================
  Files          75       75              
  Lines        2863     2869       +6     
==========================================
+ Hits         2583     2587       +4     
- Misses        280      282       +2     
Impacted Files Coverage Δ
opteryx/engine/attribute_types.py 93.54% <66.66%> (-6.46%) ⬇️
opteryx/engine/planner/operations/show_columns.py 90.62% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e881d2...ca3959c. Read the comment docs.

@joocer joocer merged commit 0576537 into main Jun 11, 2022
@joocer joocer deleted the FIX/#178 branch June 11, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant