Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1928 #1934

Merged
merged 2 commits into from
Aug 25, 2024
Merged

#1928 #1934

merged 2 commits into from
Aug 25, 2024

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Aug 25, 2024

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to help make sure it goes smoothly:

  • Raise a bug/feature request or start a discussion, ideally before writing your code! That way we can discuss the change and the approach.
  • Ensure the tests pass
  • Ensure code coverage does not decrease (if any source code was changed)
  • Appropriate docs and tests were updated (if necessary)

Fixes #<issue_number_goes_here>

@joocer joocer merged commit 0551e1d into main Aug 25, 2024
1 check was pending
@joocer joocer deleted the #1928-1 branch August 25, 2024 14:25
Copy link

sonarcloud bot commented Aug 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants