Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#669 COUNT(*) cannot be mixed with other aggregates. #677

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Conversation

joocer
Copy link
Contributor

@joocer joocer commented Nov 20, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Merging #677 (0a19bcd) into main (226fe8a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   95.06%   95.06%   -0.01%     
==========================================
  Files         155      155              
  Lines        6056     6055       -1     
==========================================
- Hits         5757     5756       -1     
  Misses        299      299              
Impacted Files Coverage Δ
opteryx/operators/aggregate_node.py 94.57% <100.00%> (-0.04%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joocer joocer merged commit 226297c into main Nov 20, 2022
@joocer joocer deleted the FIX/#669 branch November 20, 2022 16:17
@sonarcloud
Copy link

sonarcloud bot commented Nov 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ghost
Copy link

ghost commented Nov 20, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant