Add methods in powersupplies.rigol, scopes.rigol #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a syntax error in powermeters.newport preventing driver_info generation - Use correct var names so that the driver_info file can parse the other Rigol drivers - Regenerate driver_info.py
czee
changed the title
natezb
requested changes
Oct 2, 2019
| @@ -53,6 +53,8 @@ class DP700(RigolPowerSupply, VisaMixin): | |||
| current_protection_state = SCPI_Facet('SOURce:CURRent:PROTection:STATe', convert=OnOffState) | |||
| output = SCPI_Facet('OUTPut:STATe', convert=OnOffState) | |||
| beeper = SCPI_Facet('SYSTem:BEEPer', convert=OnOffState) | |||
| measured_voltage = SCPI_Facet('MEASure:VOLTage', convert=float, readonly=True, units='A') | |||
There was a problem hiding this comment.
Looks like a typo here, units should be volts
| from pint import UndefinedUnitError | ||
| from pint import UndefinedUnitError, UnitRegistry |
There was a problem hiding this comment.
Doesn't look like this new import is used anywhere
|
Thanks for this! There are just a few minor notes I had, which I reviewed above. Additionally, I'm going to hold off on accepting the VISA transaction changes until we discuss it a bit more. I'll comment about that on the separate PR you made for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drivers