Fix and reformat produced block timing log (hyperledger#6916)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
macfarla · Apr 26, 2024 · c8f5b30 · c8f5b30
1 parent 70979cd
commit c8f5b30
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/...eation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/BlockCreationTiming.java b/...eation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/BlockCreationTiming.java
@@ -49,7 +49,7 @@ public Duration end(final String step) {
 
   @Override
   public String toString() {
-    final var sb = new StringBuilder("Started at " + startedAt + ", ");
+    final var sb = new StringBuilder("started at " + startedAt + ", ");
 
     var prevDuration = Duration.ZERO;
     for (final var entry : timing.entrySet()) {

diff --git a/...m/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/BlockMiner.java b/...m/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/BlockMiner.java
@@ -168,7 +168,7 @@ protected boolean mineBlock() throws InterruptedException {
   }
 
   private void logProducedBlock(final Block block, final BlockCreationTiming blockCreationTiming) {
-    String log =
+    LOG.info(
         String.format(
             "Produced #%,d / %d tx / %d om / %,d (%01.1f%%) gas / (%s) in %01.3fs",
             block.getHeader().getNumber(),
@@ -177,13 +177,9 @@ private void logProducedBlock(final Block block, final BlockCreationTiming block
             block.getHeader().getGasUsed(),
             (block.getHeader().getGasUsed() * 100.0) / block.getHeader().getGasLimit(),
             block.getHash(),
-            blockCreationTiming.end("log").getSeconds() / 1000.0);
+            blockCreationTiming.end("log").toMillis() / 1000.0));
 
-    if (LOG.isDebugEnabled()) {
-      log = log + ", timing [" + blockCreationTiming + "]";
-    }
-
-    LOG.info(log);
+    LOG.debug("Timing #{} / {}", block.getHeader().getNumber(), blockCreationTiming);
   }
 
   public void cancel() {