Fix py ma ch3 pip install #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pip build of pyMaCh3 can properly install the module
ewanwm
requested review from
KSkwarczynski,
EdAtkin and
henry-wallace-phys
as code owners
|
Hi @ewanwm, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
… level __init__.py
…es as otherwise it breaks
KSkwarczynski
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Previously when pip installing, python was unable to find the sub-modules of pyMaCh3. Have now restructured the python directory to be more similar to a "normal" python only module so that it can now find it. ( This restructure also makes it easier to add any python only code in future if that's something we ever want to do ). the module now works when installing normally and with pip.
Changes or fixes
Examples