Feature gpu compile options #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setting up NuOscillator much easier as we need to pass the CPU compiler flags to NuOscillator
|
Hi @EdAtkin, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
github-actions
bot
added
Nu Osc/Xsec
CMakeLists.txt
Outdated
Comment on lines
24
to
25
| #Create a seperate target for GPU compiler options | ||
| add_library(MaCh3GPUCompilerOptions INTERFACE) |
There was a problem hiding this comment.
can you just move it away from if GPU?
But make it empty for CPU only build? I wonder if this will not simplyfy logic
There was a problem hiding this comment.
yep good point! I've changed this both in the main CMakeList.txt and also manager/CMakeLists.txt and splines/CMakeLists.txt
…st empty, this means fewer if statements. Also removed the GPU setting for LOW_MEMORY_STUCTS as this isn't used
KSkwarczynski
approved these changes
Dec 10, 2024
…e_gpu_compile_options Pulling in from develop to get changes to README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Making separate GPU and CPU compiler options. This is primarily so that CPU-only flags can be exported more easily to NuOscillator without the need to do some horrible regex comparisons.
Changes or fixes
A separate GPU option now exists where all of the CUDA-related flags now live.
Examples
With GPU enabled you can see the MaCh3GPUCompilerOptions and MaCh3CompilerOptions getting printed out
With CPU-only you can see only MaCh3Compiler options getting printed out
