Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy: Janitorial work for SamplePDF #252

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Conversation

KSkwarczynski
Copy link
Member

Pull request description

Minor tidy of sample pdf

Changes or fixes

  • dataSample was pointer to vector... this is terrible... I am speachless... either way it wasn't use so removed
  • We were resetting histogram in ResetHistohgram and in FillArray now we do this once
  • Remove lot of legacy stuff from PDF base
  • Moved unityf to struct instead as meber of SamplePDF
  • reuturn at the end of void is just noise

Examples

Nothing critical so I don't think valdiations other than bots are neccessary

Copy link

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions bot added MCMC MCMC related Samples labels Dec 17, 2024
@KSkwarczynski KSkwarczynski merged commit d500aec into develop Dec 19, 2024
13 checks passed
@KSkwarczynski KSkwarczynski deleted the feature_SamplePDFtidy branch December 19, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MCMC MCMC related Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant