Adaptation Handler #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| // ******************************************** | ||
| void AdaptiveMCMCHandler::InitFromConfig(const YAML::Node& adapt_manager, const std::string& matrix_name_str, const int Npars) { |
There was a problem hiding this comment.
Given Npars won't change does it not make sense to make this a class attribute rather than calling it in every method?
| if(total_steps>adaption_struct.end_adaptive_update || total_steps<adaption_struct.start_adaptive_update) return; | ||
|
|
||
| int steps_post_burn = total_steps - adaption_struct.start_adaptive_update; | ||
| if(total_steps>AdaptiveHandler.end_adaptive_update || total_steps<AdaptiveHandler.start_adaptive_update) return; |
There was a problem hiding this comment.
Conceptually do we not want to leave this logic inside the adaption handler?
…t's use cmake to update it whenver we update it in cmake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description:
Currently All AMCMC related stuff in heavily integrated within CovarianceBase. This PR attempts to make full fledget adaption class which interfaces with Covariance base. If all adaptation is done via this handler then selcting different adaptation via polimorphism will be super easy.
There are still Adaptive funciton in covaraince. This will need to be adressed later. Will try do this when I have time again.
Changes or fixes: