Remove usage of global variable in operatorrules #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
machadovilaca
commented
Jul 18, 2024
There was a problem hiding this comment.
pkg/operatorrules/compatibility_test.go is the old pkg/operatorrules/registry_test.go (which was updated to use the instance methods) and ensures the compatibility passover functions are working
machadovilaca
commented
Jul 18, 2024
There was a problem hiding this comment.
To keep backward compatibility pkg/operatorrules/compatibility.go delegates previous existing functions to the instance methods of a global variable. This is deprecated and should be removed in the future.
assafad
approved these changes
Jul 18, 2024
|
@sradco can you also take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR operator rules were stored in a global variable. This prevented a project from having multiple instances with different alerts and recording rules. This PR follows a structured approach where library users create a new instance of the registry where they can register the alerts and recording rules and old functions are now instance methods.
To keep backward compatibility
pkg/operatorrules/compatibility.gowas created that delegates previous functions to the instance methods of a global variable. This is deprecated and should be removed in the future.