The download and upload artifact GitHub actions v2 are deprecated and no longer generating screenshots

[machawk1]

EDIT: Depends on #576, see below.

[machawk1]

#572 resurfaces here, as the action installs screenshot via pip, which fails due to the environment not be isolated.

[machawk1]

While pipx can be used to isolate the environment (install via brew install pipx), the MAKEFILE uses the pip module via python3. We don't want to require those that wish to build WAIL from source to also install pipx, so a virtualenv might be the better route -- then all of the pip calls in the MAKEFILE ought to resolve as designed.

[machawk1]

Using a venv on GH Actions reports cross-architecture issues. Perhaps they use the non-universal Python on GH Action. Need to investigate.

[machawk1]

which python3 reports
/opt/homebrew/bin/python3: Mach-O 64-bit executable arm64 on GitHub Actions, which might be why the universal binary is not compiling. This is the case even before activating the venv.

[machawk1]

We don't use the setup-python action, just macos-latest and other macOS variants, so the culprit of the single-architecture Python might be the respective macOS runner.

[machawk1]

macOS runners are arm-based, as expected, but the default version of Python is solely arm-based, which is insufficient for building a universal binary.

• Can we install the universal2 Python on a macOS runner?

[machawk1]

An alternative might be that we isolate to a single architecture for the runner but leave the MAKEFILE to build a universal binary. This might also be a problem for anyone trying to build on a single architecture (non-universal) Python, which speaks for having single-architecture as a default and universal2 if available. See #576.