Add mapping for pwsh to powershell
#37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes downstream: kubernetes/minikube#12860
Using the latest version of PowerShell from https://github.com/PowerShell/PowerShell resulted in me getting the error
There are no more files.when runningshell.Detect().The error is coming from https://github.com/machine-drivers/machine/blob/master/libmachine/shell/shell_windows.go#L34 after being called from https://github.com/machine-drivers/machine/blob/master/libmachine/shell/shell_windows.go#L67.
The reason it's even hitting those parts of the code is because the .exe file of the new PowerShell is
pwsh.exewhile we're only checking forpowershell.