Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for no_std #44

Closed
wants to merge 2 commits into from
Closed

Support for no_std #44

wants to merge 2 commits into from

Conversation

michalkucharczyk
Copy link

@michalkucharczyk michalkucharczyk commented Oct 27, 2023 •
edited
Loading

Changes made in this PR allow to use tiny-bip39 crate in no_std environments.

Following modification were made:

  • once_cell::lazy replaced with lazy_static (as once_cell::lazy does not support no_std),
  • thiserror removed (it has no support for no_std),
  • BTreeMap is used in no_std instead of rustc::HashMap (probably BTreeMap could be used also in std),
  • version bumped to 1.0.1

@michalkucharczyk michalkucharczyk marked this pull request as draft October 27, 2023 11:34
@michalkucharczyk michalkucharczyk changed the title Use sha2 with no default features. Version bump: 1.0.1 Support for no-std Oct 27, 2023
@michalkucharczyk michalkucharczyk changed the title Support for no-std Support for no_std Oct 27, 2023
@michalkucharczyk michalkucharczyk mentioned this pull request Oct 27, 2023
Merged
@michalkucharczyk michalkucharczyk marked this pull request as ready for review October 27, 2023 17:01
@michalkucharczyk michalkucharczyk marked this pull request as draft October 30, 2023 06:39
@wigy-opensource-developer
Copy link

@michalkucharczyk Was there anything wrong with this PR, or did you choose another path to make no_std possible?

@michalkucharczyk
Copy link
Author

@michalkucharczyk Was there anything wrong with this PR, or did you choose another path to make no_std possible?

I've decided to use original crate: https://github.com/rust-bitcoin/rust-bip39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalkucharczyk @wigy-opensource-developer