Skip to content

Commit

Permalink
fix: remove incorrect aria hidden tags
Browse files Browse the repository at this point in the history
  • Loading branch information
@jakerenzella
jakerenzella committed Jul 14, 2023
1 parent 4695a7f commit 46bfe21
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 27 deletions.
44 changes: 21 additions & 23 deletions src/app/common/header/task-dropdown/task-dropdown.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,37 +9,37 @@
</button>
<mat-menu #menu="matMenu">
<button mat-menu-item uiSref="units/tasks/inbox" [uiParams]="{ unitId: currentUnit.id }">
<mat-icon aria-hidden="false" aria-label="Inbox icon" fontIcon="inbox"></mat-icon> <span>Inbox</span>
<mat-icon aria-label="Inbox icon" fontIcon="inbox"></mat-icon> <span>Inbox</span>
</button>
<button mat-menu-item uiSref="units/tasks/definition" [uiParams]="{ unitId: currentUnit.id }">
<mat-icon aria-hidden="false" aria-label="Task Explorer Icon" fontIcon="pageview"></mat-icon> Explorer
<mat-icon aria-label="Task Explorer Icon" fontIcon="pageview"></mat-icon> Explorer
</button>
<button mat-menu-item uiSref="units/tasks/viewer" [uiParams]="{ unitId: currentUnit.id }">
<mat-icon aria-hidden="false" aria-label="Task list icon" fontIcon="list_alt"></mat-icon> Tasks
<mat-icon aria-label="Task list icon" fontIcon="list_alt"></mat-icon> Tasks
</button>
<mat-divider></mat-divider>
<button mat-menu-item uiSref="units/students/list" [uiParams]="{ unitId: currentUnit.id }">
<mat-icon aria-hidden="false" aria-label="Students list" fontIcon="group"></mat-icon> Students
<mat-icon aria-label="Students list" fontIcon="group"></mat-icon> Students
</button>
<button mat-menu-item uiSref="units/students/groups" [uiParams]="{ unitId: currentUnit.id }">
<mat-icon aria-hidden="false" aria-label="Student Groups" fontIcon="groups"></mat-icon> Groups
<mat-icon aria-label="Student Groups" fontIcon="groups"></mat-icon> Groups
</button>
<button mat-menu-item uiSref="units/students/portfolios" [uiParams]="{ unitId: currentUnit.id }">
<mat-icon aria-hidden="false" aria-label="Student portfolios icon" fontIcon="collections_bookmark"></mat-icon>
<mat-icon aria-label="Student portfolios icon" fontIcon="collections_bookmark"></mat-icon>
Portfolios
</button>
<span>
<mat-divider></mat-divider>
<button mat-menu-item uiSref="units/analytics" [uiParams]="{ unitId: currentUnit.id }">
<mat-icon aria-hidden="false" aria-label="Unit Analytics icon" fontIcon="insights"></mat-icon>Analytics
<mat-icon aria-label="Unit Analytics icon" fontIcon="insights"></mat-icon>Analytics
</button>
<button
*ngIf="currentUnit.currentUserIsConvenor"
mat-menu-item
uiSref="units/admin"
[uiParams]="{ unitId: currentUnit.id }"
>
<mat-icon aria-hidden="false" aria-label="Unit Administration" fontIcon="admin_panel_settings"></mat-icon>
<mat-icon aria-label="Unit Administration" fontIcon="admin_panel_settings"></mat-icon>
Administration
</button>
</span>
Expand All @@ -57,24 +57,22 @@
<mat-menu #menu2="matMenu">
<ng-container *ngIf="currentProject !== null && currentView === 'PROJECT'">
<button uiSref="projects/dashboard" [uiParams]="{ projectId: currentProject.id, taskAbbr: '' }" mat-menu-item>
<mat-icon aria-hidden="false" aria-label="Dashboard icon" fontIcon="dashboard"></mat-icon> Dashboard
<mat-icon aria-label="Dashboard icon" fontIcon="dashboard"></mat-icon> Dashboard
</button>
<mat-divider></mat-divider>
<button uiSref="projects/outcomes" [uiParams]="{ projectId: currentProject.id, taskAbbr: '' }" mat-menu-item>
<mat-icon aria-hidden="false" aria-label="learning outcomes icon" fontIcon="flag"></mat-icon> Learning
Outcomes
<mat-icon aria-label="learning outcomes icon" fontIcon="flag"></mat-icon> Learning Outcomes
</button>
<button uiSref="projects/portfolio" [uiParams]="{ projectId: currentProject.id, taskAbbr: '' }" mat-menu-item>
<mat-icon aria-hidden="false" aria-label="Portfolio creation icon" fontIcon="auto_stories"></mat-icon>
<mat-icon aria-label="Portfolio creation icon" fontIcon="auto_stories"></mat-icon>
Portfolio Creation
</button>
<mat-divider></mat-divider>
<button uiSref="projects/groups" [uiParams]="{ projectId: currentProject.id, taskAbbr: '' }" mat-menu-item>
<mat-icon aria-hidden="false" aria-label="Groups list icon" fontIcon="groups"></mat-icon> Groups List
<mat-icon aria-label="Groups list icon" fontIcon="groups"></mat-icon> Groups List
</button>
<button uiSref="projects/tutorials" [uiParams]="{ projectId: currentProject.id, taskAbbr: '' }" mat-menu-item>
<mat-icon aria-hidden="false" aria-label="Tutorial List icon" fontIcon="meeting_room"></mat-icon> Tutorial
List
<mat-icon aria-label="Tutorial List icon" fontIcon="meeting_room"></mat-icon> Tutorial List
</button>
</ng-container>
<ng-container *ngIf="unitRole && currentView === 'UNIT'">
Expand All @@ -85,23 +83,23 @@
mat-menu-item
*ngIf="unitRole.role !== 'Admin'"
>
<mat-icon aria-hidden="false" aria-label="Inbox icon" fontIcon="inbox"></mat-icon> <span>Inbox</span>
<mat-icon aria-label="Inbox icon" fontIcon="inbox"></mat-icon> <span>Inbox</span>
</button>
<button
uiSref="units/tasks/definition"
[uiParams]="{ unitId: unitRole.unit.id }"
mat-menu-item
*ngIf="unitRole.role !== 'Admin'"
>
<mat-icon aria-hidden="false" aria-label="Task Explorer Icon" fontIcon="pageview"></mat-icon> Explorer
<mat-icon aria-label="Task Explorer Icon" fontIcon="pageview"></mat-icon> Explorer
</button>
<button
uiSref="units/tasks/viewer"
[uiParams]="{ unitId: unitRole.unit.id }"
mat-menu-item
*ngIf="unitRole.role !== 'Admin'"
>
<mat-icon aria-hidden="false" aria-label="Task list icon" fontIcon="list_alt"></mat-icon> Tasks
<mat-icon aria-label="Task list icon" fontIcon="list_alt"></mat-icon> Tasks
</button>
<mat-divider *ngIf="unitRole.role !== 'Admin'"></mat-divider>
<!-- <p class="task-dropdown-heading">Students</p> -->
Expand All @@ -111,23 +109,23 @@
mat-menu-item
*ngIf="unitRole.role !== 'Admin'"
>
<mat-icon aria-hidden="false" aria-label="Students list" fontIcon="group"></mat-icon> Students
<mat-icon aria-label="Students list" fontIcon="group"></mat-icon> Students
</button>
<button
uiSref="units/students/groups"
[uiParams]="{ unitId: unitRole.unit.id }"
mat-menu-item
*ngIf="unitRole.role !== 'Admin'"
>
<mat-icon aria-hidden="false" aria-label="Student Groups" fontIcon="groups"></mat-icon> Groups
<mat-icon aria-label="Student Groups" fontIcon="groups"></mat-icon> Groups
</button>
<button
uiSref="units/students/portfolios"
[uiParams]="{ unitId: unitRole.unit.id }"
mat-menu-item
*ngIf="unitRole.role !== 'Admin'"
>
<mat-icon aria-hidden="false" aria-label="Student portfolios icon" fontIcon="collections_bookmark"></mat-icon>
<mat-icon aria-label="Student portfolios icon" fontIcon="collections_bookmark"></mat-icon>
Portfolios
</button>

Expand All @@ -139,15 +137,15 @@
mat-menu-item
*ngIf="unitRole.role !== 'Admin'"
>
<mat-icon aria-hidden="false" aria-label="Unit Analytics icon" fontIcon="insights"></mat-icon>Analytics
<mat-icon aria-label="Unit Analytics icon" fontIcon="insights"></mat-icon>Analytics
</button>
<button
uiSref="units/admin"
[uiParams]="{ unitId: unitRole.unit.id }"
*ngIf="unitRole.role === 'Convenor' || unitRole.role === 'Admin'"
mat-menu-item
>
<mat-icon aria-hidden="false" aria-label="Unit Administration" fontIcon="admin_panel_settings"></mat-icon>
<mat-icon aria-label="Unit Administration" fontIcon="admin_panel_settings"></mat-icon>
Administration
</button>
</ng-container>
Expand Down
1 change: 0 additions & 1 deletion src/app/common/header/unit-dropdown/unit-dropdown.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
style="margin-right: 20px"
svgIcon="formatif-logo"
class="formatif-icon"
aria-hidden="false"
aria-label="Home Icon"
></mat-icon>
<div class="unitName">Home</div>
Expand Down
4 changes: 2 additions & 2 deletions ...ives/task-dashboard/directives/task-description-card/task-description-card.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@
</mat-card-content>
<mat-card-actions [hidden]="!(taskDef?.hasTaskSheet || taskDef?.hasTaskResources)">
<button mat-button [hidden]="!taskDef?.hasTaskSheet" (click)="downloadTaskSheet()">
<mat-icon aria-hidden="false" aria-label="Download icon">cloud_download</mat-icon> Task Sheet
<mat-icon aria-label="Download icon">cloud_download</mat-icon> Task Sheet
</button>
<button mat-button [hidden]="!taskDef?.hasTaskResources" (click)="downloadResources()">
<mat-icon aria-hidden="false" aria-label="Download icon">cloud_download</mat-icon> Resources
<mat-icon aria-label="Download icon">cloud_download</mat-icon> Resources
</button>
</mat-card-actions>
</mat-card>
1 change: 0 additions & 1 deletion src/app/tasks/task-comment-composer/task-comment-composer.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@
matTooltipShowDelay="400"
id="emojiButton"
(click)="this.showEmojiPicker = !this.showEmojiPicker"
aria-hidden="false"
aria-label="Emoji picker button"
>
emoji_emotions</mat-icon
Expand Down

0 comments on commit 46bfe21

Please sign in to comment.