Build with go v1.22 #212
Merged
Build with go v1.22 #212
+9
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lufia
reviewed
Jun 5, 2024
go.mod
Outdated
| @@ -1,9 +1,10 @@ | |||
| module github.com/mackerelio-labs/terraform-provider-mackerel | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
In Go 1.21 or higher versions, this means... "Go 1.22 development version", so 1.22 < 1.22rc1, 1.22.0, 1.22.1...
So, in my opinion for now, it's better to describe go 1.22.0 and go-version: 1.22.x (not go-version-file.)
There was a problem hiding this comment.
Thank you, I fixed it: a4c42f7
lufia
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates go version.
I introduced
slicesin #209, but go version is still v1.21.x, which broke CI.I'm going to fix that.