refactor: lint and test workflows #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lufia
force-pushed
the
refactor-wf
branch
3 times, most recently
from
0add427
to
d2cfbdf
Compare
For instance, `echo xx"$(wc -l </dev/null)"xx` outputs * on linux runners: xx0xx * on macos runners: xx 0xx Therefore we shouldn't compare output of `wc -l` to 0 by string equal operator(=).
lufia
force-pushed
the
refactor-wf
branch
2 times, most recently
from
c7e36ea
to
1c36516
Compare
gofmt formats all CRLF to LF in *.go files. it results failure of convention job on GitHub Actions, especially on windows host runners.
lufia
commented
Feb 26, 2024
Comment on lines
-54
to
-55
| run: | | ||
| go test -short ./... |
There was a problem hiding this comment.
-short no longer reduce anything
This was referenced Mar 19, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed these jobs: