Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept UTF8-BOM when reading dashboard or monitor from JSON file #622

Merged
merged 9 commits into from
Jan 22, 2024
Merged

accept UTF8-BOM when reading dashboard or monitor from JSON file #622

merged 9 commits into from
Jan 22, 2024

Commits on Jan 16, 2024

  1. accept UTF8BOM for dashboard JSON file

    @kmuto
    kmuto committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    0a1a890 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. accept BOM in monitors pull/diff also

    @kmuto
    kmuto committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    c348e24 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. test unit for monitorLoadRules. check it accepts a JSON content with BOM

    @kmuto
    kmuto committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0783434 View commit details
    Browse the repository at this point in the history

  2. check err for Seek

    @kmuto
    kmuto committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    05275c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Update monitors/command_test.go 

    Co-authored-by: KADOTA, Kyohei <lufia@users.noreply.github.com>
    @kmuto @lufia
    kmuto and lufia authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9455db9 View commit details
    Browse the repository at this point in the history

  2. use TempDir instead of CreateTemp

    @kmuto
    kmuto committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    8df6538 View commit details
    Browse the repository at this point in the history

  3. close tmpFile

    @kmuto
    kmuto committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    3295eed View commit details
    Browse the repository at this point in the history

  4. close in t.Cleanup

    @kmuto
    kmuto committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    db949f8 View commit details
    Browse the repository at this point in the history

  5. revert modifying to use TempDir

    @kmuto
    kmuto committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    c401adc View commit details
    Browse the repository at this point in the history