Support provided value in form helper #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maclover7
reviewed
Jul 16, 2017
| @@ -36,7 +36,7 @@ def render | |||
| options = @options.stringify_keys | |||
| add_default_name_and_id(options) | |||
| options['input'] ||= dom_id(object, [options['id'], :trix_input].compact.join('_')) | |||
| trix_editor_tag(options.delete('name'), value_before_type_cast(object), options) | |||
| trix_editor_tag(options.delete('name'), (options['value'] || value_before_type_cast(object)), options) | |||
There was a problem hiding this comment.
Can you extract the value setting to a separate variable?
|
Sorry for takin so long to get to this PR. If you can make the change requested and rebase, I'd be happy to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my form fields have default values, like so:
In this case, I want to pass the value of the form field explicitly. Rails' default form helpers allow this, but it did not work with the
trix_editorhelper. This PR enables it.I'm not sure if more has to be done to support Formtastic.