Skip to content

Commit

Permalink
hdf5: Revert to normal linker
Browse files Browse the repository at this point in the history
.

Revert workaround for Sonoma/Xcode 15.0.
`ld_classic` is no longer needed with HDF5 1.14.3.
HDFGroup/hdf5#3571
HDFGroup/hdf5#3581
"Removed "-commons" linking option on Darwin"
https://github.com/HDFGroup/hdf5/blob/hdf5_1_14_3/release_docs/RELEASE.txt
  • Loading branch information
Dave-Allured authored and pmetzger committed Nov 16, 2023
1 parent 286965e commit ae18f8f
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions science/hdf5/Portfile
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,6 @@ configure.args \
--with-szlib=${prefix}/lib/libaec \
--with-zlib=yes

if { [vercmp ${xcodeversion} >= 15.0] || [vercmp ${xcodecltversion} >= 15.0] } {
# On macOS13 and newer ensure the 'legacy' linker is used as GCC currently has problems
# with the new default linker in Xcode 15. See e.g.
# https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Linking
# https://discussions.apple.com/thread/255137447
# https://developer.apple.com/forums/thread/737707
# https://github.com/Homebrew/homebrew-core/issues/145991
configure.env LDFLAGS=-ld_classic
}

# Actively checks how to get clang to warn on implicit functions with this.
configure.checks.implicit_function_declaration.whitelist-append strchr

Expand Down

2 comments on commit ae18f8f

@Dave-Allured
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake. Rev bump port hdf5 was not included, therefore hdf5 builds were not updated, leaving errors in dependent ports that updated to Xcode 15 linker. Will push out a new rev bump to correct.

@Dave-Allured
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! Tested rev bump. Did not fix duplicate LC_RPATH's in hdf5-fortran libraries. The fix is not obvious to me. More work needed.

Please sign in to comment.