barrier: fix build with gcc

[barracuda156]

Description

Fix the build on systems using gcc

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL in commit message?
• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@ryanakca for port barrier.

[reneeotten]

did you submit any of these patches upstream? Please add a link or do so

[barracuda156]

did you submit any of these patches upstream? Please add a link or do so

@reneeotten Those are not needed with clang builds (which is why they are applied conditionally on gcc in use) and partially incompatible with the current way upstream builds this. And it will be pointless to apply them partially, since that is not sufficient to make gcc build work.

[reneeotten]

most of the patches seem like they would be okay regardless if the compiler used and could/should thus be send upstream.

[barracuda156]

@reneeotten Ok, I recalled now, I did not submit cstdint fix because there is already an existing PR for it: debauchee/barrier#1886

I think everything else is just tweaking the build to work for gcc, which does not support Apple ObjC/ObjC++ syntax fully.
I can try opening PR for some of that, but do not really expect it to get merged.

UPD. debauchee/barrier#2112

[barracuda156]

@reneeotten @herbygillot Could we merge this?

As you can see from the fact that an absolutely credible and minimal fix for modern gcc is still pending in upstream, they are not quick with merging anything, it is pointless to wait. There were folks wanting specifically this port on powerpc, let them have it, since I doubt they are using my fork of MacPorts, and also they were on Leopard, not 10.6 ppc.

[reneeotten]

this needs the os.platform check as well