-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdfpc: update to 4.7.0, fix build on powerpc #27119
Conversation
Notifying maintainers: |
macOS 15 CI fails on a dependency, so unrelated.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. However, version 4.7.0 got released just three days ago. Maybe, consider to update this PR to the latest release.
Ok, I will do this today. Upd. Done, rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! You may change the title of this PR to reflect the updated version.
Fair enough, done. |
this fails everywhere on the CI - please take a look. One message is: -- No package 'webkit2gtk-4.1' found |
@reneeotten Thanks, I will check that. (This dependency is not used on powerpc, as per portfile, so no error locally.) |
@reneeotten @maehne Looks like they want a much newer version than MacPorts has: https://ports.macports.org/port/webkit2-gtk Solution would be either to keep the port at 4.6.0 and just fix it (what I did originally) or update it to 4.7.0, but disable You tell me what to do, I would like to close this PR this or that way. Preferably merging, but not leaving pending. |
I have personally no interest in this port, so don't care which solution is picked. I am fine with merging it with disabling the failing But before I can/will merge the CI has to pass. |
@reneeotten Yes, of course. Will sort that out. |
@reneeotten This is ready now, on macOS 15 it is a dependency that fails:
|
Description
Update, fix
Type(s)
Tested on
macOS 10.6
Xcode 3.2
Verification
Have you
port lint
?sudo port test
?sudo port -vst install
?