Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfpc: update to 4.7.0, fix build on powerpc #27119

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

barracuda156
Copy link
Contributor

Description

Update, fix

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@maehne for port pdfpc.

@barracuda156
Copy link
Contributor Author

macOS 15 CI fails on a dependency, so unrelated.

Building dependency (1 of 304) 'discount' with variants '' ... [FAIL]

Copy link
Contributor

@maehne maehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, version 4.7.0 got released just three days ago. Maybe, consider to update this PR to the latest release.

@barracuda156
Copy link
Contributor Author

barracuda156 commented Dec 21, 2024

Looks good to me. However, version 4.7.0 got released just three days ago. Maybe, consider to update this PR to the latest release.

Ok, I will do this today.

Upd. Done, rebased.

Copy link
Contributor

@maehne maehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! You may change the title of this PR to reflect the updated version.

@barracuda156 barracuda156 changed the title pdfpc: update to 4.6.0, fix build on powerpc pdfpc: update to 4.7.0, fix build on powerpc Dec 21, 2024
@barracuda156
Copy link
Contributor Author

Looks good to me! You may change the title of this PR to reflect the updated version.

Fair enough, done.

@reneeotten
Copy link
Contributor

this fails everywhere on the CI - please take a look. One message is:

-- No package 'webkit2gtk-4.1' found

@barracuda156
Copy link
Contributor Author

@reneeotten Thanks, I will check that. (This dependency is not used on powerpc, as per portfile, so no error locally.)

@barracuda156
Copy link
Contributor Author

barracuda156 commented Dec 23, 2024

@reneeotten @maehne Looks like they want a much newer version than MacPorts has: https://ports.macports.org/port/webkit2-gtk
Can’t do anything about this. I am not gonna try updating webkit2-gtk.

Solution would be either to keep the port at 4.6.0 and just fix it (what I did originally) or update it to 4.7.0, but disable webkit2-gtk unconditionally. Or do nothing and leave it broken.

You tell me what to do, I would like to close this PR this or that way. Preferably merging, but not leaving pending.

@reneeotten
Copy link
Contributor

reneeotten commented Dec 24, 2024

You tell me what to do, I would like to close this PR this or that way. Preferably merging, but not leaving pending.

I have personally no interest in this port, so don't care which solution is picked. I am fine with merging it with disabling the failing webkit2-gtk, if @maehne wants to re-enable the option that requires a newer version of webkit2-gtk; then he has to work on updating that package as well.

But before I can/will merge the CI has to pass.

@barracuda156
Copy link
Contributor Author

But before I can/will merge the CI has to pass.

@reneeotten Yes, of course. Will sort that out.

@barracuda156
Copy link
Contributor Author

@reneeotten This is ready now, on macOS 15 it is a dependency that fails:

Building 259 dependencies of pdfpc:
 Building dependency (1 of 259) 'discount' with variants '' ... [FAIL]

@reneeotten reneeotten merged commit 237e08d into macports:master Dec 24, 2024
2 of 3 checks passed
@barracuda156 barracuda156 deleted the pdfpc branch December 24, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants