-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
krunkit libkrun virglrenderer: new ports #27208
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the submissions @tsujp. I've left a few comments, they apply to all ports.
Also, each ports should be in a different commit please.
@@ -0,0 +1,100 @@ | |||
# -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4 | |||
|
|||
# Upstream build source (until more official): https://github.com/slp/homebrew-krunkit/blob/main/Formula/krunkit.rb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove unneeded comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be useful for now though as that's how the software should be built? Makes it easier to view those files as (if) things change?
* Specifically this is slp's fork for use in libkrun.
* Specifically this is the EFI flavour for use in krunkit.
d983377
to
d7509e7
Compare
Changes made; requested re-review. |
I note that It fails around extracting virglrenderer (as of course it prompts to install dependencies). I'm very tired right now so I'm not sure why or if it's actually important?
|
Description
Three (3) new ports:
krunkit allows running VMs on macOS using Hypervisor.framework with hardware accelerated graphics using Venus.
Podman can also use krunkit as a driver instead of the default applehv (Virtualization.framework). If you configure Podman to use krunkit you can run hardware accelerated graphics workloads within the VM (and thus containers) Podman manages on your macOS hosts.
libkrun allows use of more modern versions of virtio and has some advanced networking features (although the latter is not enabled by default nor available at all as I cannot be bothered).
There are a few questions I have regarding this:
libkrun
variant to the Podman port, this would simply addkrunkit
as a runtime dependency. Strictly speaking uninstallingkrunkit
would not break Podman as Podman executes the binarykrunkit
when configured to use it. It does feel nicer to be able to install Podman withkrunkit
in one go though. Shall I add said variant?virglrenderer
here is slp's fork as already mentioned. Would you prefer I change the Portfile to use upstreamvirglrenderer
and add alibkrun
variant tovirglrenderer
which uses slp's or shall we leave the Portfile as-is only use slp's for now? In the former case how does one specify a variant inbuild_run
?Once those questions have answers I can do some final cleanup on the Portfiles (as I've left the TODOs in so I do not forget).
Type(s)
Tested on
macOS 14.5 23F79 arm64
Xcode 16.0 16A242d
Verification
Have you
port lint
?sudo port -vst install
?