openssh: update to 8.4p1, drop keychain patch and hpn variant #9451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macportsbot
added
by: member
|
Seems there's a bit of a mashup in the commit message now :) |
|
Indeed! I should read my local wiki notes all the way though before pushing a squash commit... I forgot to use --force! Lots of unnecessary extra work. |
|
Removed obsolete |
|
The commit message is still broken. |
|
So it is! I didn't catch that a premature press of the |
neverpanic
requested changes
Dec 17, 2020
| 0002-Apple-keychain-integration-other-changes.patch \ | ||
| macports-config.patch \ | ||
| patch-openbsd_compat-memmem-bug.diff | ||
| macports-config.patch | ||
|
|
||
| # We need a couple of patches |
There was a problem hiding this comment.
This comment needs adjusting – it still references 0002-Apple-keychain-integration-other-changes.patch that is now gone.
update gsskex and macports-config patches
neverpanic
approved these changes
Dec 19, 2020
|
I did build all variants. However, I normally install the default variants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update gsskex and macports-config patches
Description
openssh has been updated several times upstream since the last MacPorts update.
MacPorts has tried to maintain the unsupported Apple keychain patch.
Homebrew dropped support for this patch in 2016: https://archive.is/hSB6d#10%25
7.7p1, in 2018, was the last version to support the hpn option in FreeBSD Freshports:
https://www.freshports.org/security/openssh-portable/
Type(s)
Tested on
macOS 10.14.6 18G6042
Xcode 10.3 10G8
Verification
Have you
port lint?sudo port -vst install?