Skip to content

Commit

Permalink
fixup! Set up CI to link against Sparkle 1 when in legacy builds
Browse files Browse the repository at this point in the history
Use better `ln` command, and make sure non-publish builds don't have
Sparkle enabled so that it doesn't have to worry about using Sparkle 1
(since the OS is too old to use Sparkle 2), and to help test
--disable-sparkle builds in the matrix.
  • Loading branch information
ychin committed Nov 1, 2022
1 parent 0667ce7 commit c934190
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/ci-macvim.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
# Use Sparkle 1 because Sparkle 2 requires newer OS version than our legacy build.
# Later, we pass the --enable-sparkle_1 flag to configure to set the corresponding ifdef.
rm src/MacVim/Sparkle.framework && ln -s Sparkle_1.framework src/MacVim/Sparkle.framework
ln -fhs Sparkle_1.framework src/MacVim/Sparkle.framework
# Set up, install, and cache gettext library for localization.
#
Expand Down Expand Up @@ -158,6 +158,8 @@ jobs:
else
CONFOPT+=(
--with-macarchs=x86_64
--enable-sparkle_1 # Use juse Sparkle 1 as non-publish builds tend to use older OS / SDKs and won't support Sparkle 2
--disable-sparkle # Disable Sparkle for testing that it builds and works
)
fi
if ${{ matrix.legacy == true }}; then
Expand Down

0 comments on commit c934190

Please sign in to comment.