Switch Sparkle appcast to use macvim.org domain name #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch Sparkle's appcast URL to use macvim.org instead of raw GitHub URL. This is more public facing, and gives us more power to maintain control of the updater (as long as we keep control over the domain name), and make it possible to migrate to other platforms from GitHub (if we so wish in the future). The current URL for the appcast is actually quite problematic as it for some reason point directly to GitHub's raw content of the file, instead of the version generated by GitHub Pages. That means we can't really use GitHub Page's Jekyll static site generator to dynamically create the file (latest.xml) as the raw URL directly reads the source code rather than the generated link on GitHub Page (in which case I don't know why we bothered to put in on a gh-page branch to begin with). Since some people only open / update MacVim infrequently, that means we can't really change latext.xml to be generated by Jekyll in foreseeable future (at least a year or so) as we don't want to break not-too-old MacVim versions' ability to update. The ability to dynamically generate it would have been useful to handle legacy (pre-10.13) and beta releases.
ychin
force-pushed
the
sparkle-use-macvim-org-appcast
branch
from
19e95b8 to
d65c0f2
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Sparkle's appcast URL to use macvim.org instead of raw GitHub URL. This is more public facing, and gives us more power to maintain control of the updater (as long as we keep control over the domain name), and make it possible to migrate to other platforms from GitHub (if we so wish in the future).
The current URL for the appcast is actually quite problematic as it for some reason point directly to GitHub's raw content of the file, instead of the version generated by GitHub Pages. That means we can't really use GitHub Page's Jekyll static site generator to dynamically create the file (latest.xml) as the raw URL directly reads the source code rather than the generated link on GitHub Page (in which case I don't know why we bothered to put in on a gh-page branch to begin with).
Since some people only open / update MacVim infrequently, that means we can't really change latext.xml to be generated by Jekyll in foreseeable future (at least a year or so) as we don't want to break not-too-old MacVim versions' ability to update. The ability to dynamically generate it would have been useful to handle legacy (pre-10.13) and beta releases.