Fix misc MacVim warnings and treat warnings as errors in CI #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
added
Infrastructure
In CI, turn on warnings as errors, but ignore deprecated warnings as we are still using NSConnection right now and we won't be fixing that for now. Don't turn on warnings as errors for development (similar to Vim itself) / outside of CI, because it could make it annoying to build MacVim locally and across different Xcode versions. Fix the misc warnings. A lot of 64/32-bit warnings due to careless casts of NSInteger/NSUInteger. Also fix up MacVimTests so the waiting for Vim window is more robust when waiting for 2 windows in a row in vim tutor. Otherwise sometimes the tests would randomly fail in CI.
ychin
force-pushed
the
fix-macvim-warnings
branch
from
cf4e252 to
b6f7d7d
Compare
ychin
added a commit
to ychin/macvim
that referenced
this pull request
Sep 11, 2024
This was introduced by macvim-dev#1457 which was supposed to be a simple compiler warning cleanup but it introduced a signed integer bug. Fix that here. Fix macvim-dev#1473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI, turn on warnings as errors, but ignore deprecated warnings as we are still using NSConnection right now and we won't be fixing that for now. Don't turn on warnings as errors for development (similar to Vim itself) / outside of CI, because it could make it annoying to build MacVim locally and across different Xcode versions.
Fix the misc warnings. A lot of 64/32-bit warnings due to careless casts of NSInteger/NSUInteger.
Also fix up MacVimTests so the waiting for Vim window is more robust when waiting for 2 windows in a row in vim tutor. Otherwise sometimes the tests would randomly fail in CI.