Use getregion() for showing definition of selected texts #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, MacVim added custom VimScript to query what the user selected text is before calling `showdefinition` on it. Since Vim has since implemented the `getregion()` API that provides that info natively, use that API instead of the custom implementation. Also, the previous implementation was broken when dealing with wide characters where it would select more characters than necessary. Using the native `getregion()` is much more robust and handle those situations.
Just as an example of the current bug, if you paste in the Chinese text from the Hawaii Wikipedia article (Chinese version): "夏威夷州是位於美國西部的州", and then select "夏威夷" (Hawaii) and right click -> Look Up, current Vim shows this where it somehow thinks we have selected "夏威夷州是位於": 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, MacVim added custom VimScript to query what the user selected text is before calling
showdefinitionon it. Since Vim has since implemented thegetregion()API that provides that info natively, use that API instead of the custom implementation.Also, the previous implementation was broken when dealing with wide characters where it would select more characters than necessary. Using the native
getregion()is much more robust and handle those situations.