Move publishType and ivyRepositoryPattern to NexusRepository #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes more sense to have these properties configured on an individual repository level rather than at the plugin level This will allow the configuration of repositories with different publication types and repository layouts, mimics the original gradle configuration more closely
marcphilipp
approved these changes
May 25, 2023
| repositories { | ||
| myNexus { | ||
| nexusUrl = uri('${server.baseUrl()}/shouldNotBeUsed') | ||
| snapshotRepositoryUrl = uri('${server.baseUrl()}/snapshots') | ||
| allowInsecureProtocol = true | ||
| username = 'username' | ||
| password = 'password' | ||
|
|
||
| ivyPatternLayout { |
There was a problem hiding this comment.
Suggested change
| ivyPatternLayout { | |
| ivyPatternLayout { |
| @@ -33,6 +36,9 @@ open class NexusRepository @Inject constructor(@Input val name: String, project: | |||
| @Input | |||
| val snapshotRepositoryUrl = project.objects.property<URI>() | |||
|
|
|||
| @Input | |||
| val publicationType: Property<NexusPublishExtension.PublicationType> = project.objects.property<NexusPublishExtension.PublicationType>().value(NexusPublishExtension.PublicationType.MAVEN) | |||
There was a problem hiding this comment.
I guess we cannot use convention because we need to support older versions of Gradle, right?
There was a problem hiding this comment.
exactly, convention was introudced in 5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes more sense to have these properties configured on an individual repository level rather than at the plugin level This will allow the configuration of repositories with different publication types and repository layouts, mimics the original gradle configuration more closely