feat: Reorg Support (WIP) #296
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
changed the base branch from
main
to
notlesh/add_mc_db_testing_to_fix_tests
1 task
notlesh
force-pushed
the
notlesh/add_mc_db_testing_to_fix_tests
branch
from
61a00a8 to
75309b7
Compare
|
As of 1d5184d, I think the Bonsai tries are properly reverted (for a simple case, anyway). There are a number of DB operations that I will need to perform, however, and it's not clear exactly what that is. Any pointer here would be appreciated. It looks like contract storage changes will need to be explicitly reverted as well. The docs here discuss the rocksdb iterator which could be used to clear out items from block N onward, but we would still want a list of modified keys to avoid touching every storage item in the db. Are other items (such as |
notlesh
force-pushed
the
notlesh/add_mc_db_testing_to_fix_tests
branch
from
75309b7 to
11f96cc
Compare
Base automatically changed from
notlesh/add_mc_db_testing_to_fix_tests
to
main
October 7, 2024 08:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for reverting state during a reorg.
Originally, the goal was to detect reorgs and handle them, but the block import pipeline does not seem like the appropriate place for this detection. So the PR currently adds a
fn reorg()which does the logic of reverting the databases to a desired block along with tests around this.Pull Request type
Feature
What is the current behavior?
I expect reorgs would be dropped currently because a block's parent_header is checked against the tip of the chain and an error is produced if the two don't match.
Resolves: #202 #416
What is the new behavior?
TODO:
Does this introduce a breaking change?
TODO: