perf(get events)

[Trantorian1]

Pull Request type

• Refactoring (no functional changes, no API changes)

What is the current behavior?

The current implementation of starknet_getEvents in Madara suffers from very poor performance compared to other nodes. This pr's goal is to improve this (will benchmark this again before un-drafting the pull request).

starknet_getEvents performance across nodes, bench measured with sync from a local fgw

What is the new behavior?

• Refactored block event retrieval to avoid unnecessary allocations, clones and key checks
• Better handling of StarknetRpcApiError::BlockNotFound edge cases.
• Added tests to starknet_getEvents to ensure proper functionality

Note

Further new behavior will be documented as this PR is developed

Does this introduce a breaking change?

Yes. Calls to starknet_getEvent would previously return Ok() if from_block or to_block were higher than the latest block. This has been changed to return StarknetRpcApiError::BlockNotFound.