Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 70 - Update to pegdown-1.5.0 #72

Merged
merged 6 commits into from
Mar 13, 2015
Merged

Conversation

rmburkhead
Copy link
Contributor

Issue #70 - nb8 branch - Update pegdown to 1.5.0 (along with its requirement, parboiled, to 1.1.7). Two pegdown changes impact this module:

  • LinkRenderer.Renderer href (and other fields) now final. Implemented a relatively naive copy of the rendered link when needed. This might be brittle if the LinkRenderer.Renderer class changes structure.
  • Pegdown now has a token for anchor links. Added handling for them where required, using AUTOLINK as a template.

Comparing the rendered HTML output of v2.0 of the plugin to the changes made by this pull request, the only significant change seems to be that H1 headings now have a wrapped anchor link.

@rmburkhead
Copy link
Contributor Author

Verified that both #56 and #49 appear to be resolved by updating pegdown to this version, using the markdown examples supplied in each issue.

@madflow
Copy link
Owner

madflow commented Mar 13, 2015

This is great - thanks! The code looks fine - I'll merge it right aways to make testing easier.

madflow added a commit that referenced this pull request Mar 13, 2015
Issue 70 - Update to pegdown-1.5.0
@madflow madflow merged commit 35926e6 into madflow:nb8 Mar 13, 2015
@rmburkhead rmburkhead deleted the issue_70 branch March 13, 2015 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants