[201911]caclmgrd: Accomadating case insensitive rule props for Contro… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is an internal PR, closing this PR since the corresponding Azure PR got merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l plane ACLs
- Why I did it
To make Control plane ACLs handle case insensitive ACL rules. Currently, it handles only upper case ACL rules.
- How I did it
I set the rule prop dictionary to be all upper case before reading the rule props for processing.
- How to verify it
Configure ACL rules with any combination of case of ACL rules, either it be upper case or lower case. All rules should be created properly in the switch and working properly.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
The change is a one line change in caclmgrd script.
- A picture of a cute animal (not mandatory but encouraged)