This repository has been archived by the owner on Dec 21, 2024. It is now read-only.
Suggestions: second are lost in default date serialization + XML test broken #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the `datefmt` parameter is intended to be used by logging.Formatter.formatTime and not for the serialization * seconds are lost in the serialization of time and datetimes instances
Fix typo introduced in b13299c when "testJsonLogger" was renamed in "TestJsonLogger" but not in the called test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
here are some suggestions:
datetimeinstancesdatefmtparameter tologging.Formatterinstances should be used only to format the message time; not to serialize the dataRegards.