wire.destroy does not remove the peer from the swarm

[Ayms]

Similar to mafintosh/utp#3

wire.destroy is calling wire.end() which will fire the finish event but the end event is never fired so wire.on('end',..) will never be called and the peer will not be removed from the swarm.

Maybe the fix is to add self.emit('end') in the function attached to the finish event

[mafintosh]

wire.destroy triggers close which results in this being run https://github.com/mafintosh/peer-wire-swarm/blob/master/index.js#L329 so it should remove the peer from the swarm

[Ayms]

swarm._remove is not called, so swarm._peer[addr] is not deleted

The use case is a successful TCP connection to a peer that does not answer to the handshake and close the connection.

[mafintosh]

In that case this is a bug in peer-wire-swarm which might be missing an close handler. This line will emit end after the stream has been drained https://github.com/mafintosh/peer-wire-protocol/blob/master/index.js#L66.

Could you open an issue in peer-wire-swarm for a missing close handler?

[mafintosh]

See the core stream docs for an explanation of the .push(null) logic, http://nodejs.org/api/stream.html

[Ayms]

So maybe it's a node bug, you can see whatwg/streams#13, where you can notice that the drain method is not totally clear, or other discussions I am participating to regarding node/W3C-WHATWG Streams, where some things remain unclear too.

So, until it stabilizes I am not willing to go into more details about streams and the supposed behavior of push(null), there is probably a more straight forward solution, the bug is open too in peer-wire-swarm but now what should happen between both modules is up to you, self.emit('end') in finish just works fine for now until push(null) fires end, but this is really a detail, if you call destroy you don't care about the remaining data to be drained.