Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire.destroy does not remove the peer from the swarm #10

Open
Ayms opened this issue Oct 14, 2014 · 3 comments
Open

wire.destroy does not remove the peer from the swarm #10

Ayms opened this issue Oct 14, 2014 · 3 comments

Comments

@Ayms
Copy link

Ayms commented Oct 14, 2014

Please see mafintosh/peer-wire-protocol#7
@Ayms
Copy link
Author

Ayms commented Oct 16, 2014

Is wire.on('end',... ever called by any module?

The fix could be to replace it by wire.on('close',...

@mafintosh
Copy link
Owner

Yes end is used if the connection ends "nicely" and close is used if the connection is destroyed. We should probably just use both. Up for a PR? :)

@Ayms
Copy link
Author

Ayms commented Oct 16, 2014

Yes, I will do it with some other PRs, not now but soon I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mafintosh @Ayms