Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

Eliminate usage of ZF1 components #64

Open
vkublytskyi opened this issue Feb 17, 2018 · 0 comments
Open

Eliminate usage of ZF1 components #64

vkublytskyi opened this issue Feb 17, 2018 · 0 comments
Labels

Comments

@vkublytskyi
Copy link

vkublytskyi commented Feb 17, 2018

Usage of ZF1 components in Magento should be eliminated and replaced by (in preference order):

  • embedded PHP libraries (e.g. Intl)
  • ZF2/ZF3 component
  • other well-supported stable PHP

During elimination of ZF1 components, backward compatibility changes are allowed but should be well motivated and provided with an explanation why this is necessary. If backward incompatible changes are made and removed ZF1 component was exposed in Magento interface/classes signatures, new code must wrap any usage of any 3rd party library (it is not allowed to expose usage of 3rd party libraries in Magento signatures)

Static Tests for eliminated components

To avoid regression issues with the introduction of new dependencies on the already cleaned usage of ZF1 components static tests should be implemented.
One of possible solution is reuse of dev/tests/static/testsuite/Magento/Test/Legacy/_files/restricted_classes.php. More accurate way would be to introduce special check that would understand Zend components structure (aka PSR-0 restricted namespaces)

Caused by #22

magento-team pushed a commit that referenced this issue Aug 26, 2018
MAGETWO-91493: MDC Framework Issues. Message passed as a service to T…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants