Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 291c42f896d0da61125ec654ff6a67a42a8236cd commit #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ikruchynskyi
Copy link

@ikruchynskyi ikruchynskyi commented Dec 21, 2022

This reverts commit 291c42f.

Reverts changes which introduced the bug into m2install.sh:

Steps to reproduce:

  1. Collect code and DB dumps
  2. Navigate to folder which contains code and DB dumps archives.
  3. Run m2install.sh

Actual result:
/usr/local/bin/m2install.sh: line 324: -r: command not found
As a result m2install will produce output like the next during DB dump restoration:

ERROR 1046 (3D000) at line 7184: No database selected
ERROR 1046 (3D000) at line 7187: No database selected
ERROR 1046 (3D000) at line 7207: No database selected
ERROR 1046 (3D000) at line 7210: No database selected

Expected result:
m2install.sh should be able to determine DB name to run DB dump import without issues.

Link to the failing code line: https://github.com/yvoronoy/m2install/blob/master/m2install.sh#L324

This reverts commit 291c42f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant