Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPTC Reader && Writer Implementation for jpeg format #1550

Merged
merged 27 commits into from
Jul 4, 2020
Merged

IPTC Reader && Writer Implementation for jpeg format #1550

merged 27 commits into from
Jul 4, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jul 1, 2020 •
edited by sivaschenko
Loading

Description (*)

Story #1183: Magento extracts image meta data from file
Introduced IPTC reader and writer for all supported image formats

Fixed Issues (if relevant)

  1. Fixes Create IPTC reader #1451: Create IPTC reader
  2. Fixes Create IPTC writer #1454: Create IPTC writer

@Nazar65 Nazar65 marked this pull request as draft July 1, 2020 13:09
@Nazar65 Nazar65 changed the title [WIP] Iptc Reader && Writer Implementation for all suported images format [WIP] IPTC Reader && Writer Implementation for all suported images format Jul 1, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 2, 2020

@magento run all tests

@Nazar65 Nazar65 changed the title [WIP] IPTC Reader && Writer Implementation for all suported images format IPTC Reader && Writer Implementation for all suported images format Jul 2, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 3, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 3, 2020

@magento run all tests

@Nazar65 Nazar65 changed the title IPTC Reader && Writer Implementation for all suported images format IPTC Reader && Writer Implementation Jul 3, 2020
@Nazar65 Nazar65 changed the title IPTC Reader && Writer Implementation IPTC Reader && Writer Implementation for jpeg format Jul 3, 2020
@Nazar65 Nazar65 marked this pull request as ready for review July 3, 2020 08:21
sivaschenko
sivaschenko previously approved these changes Jul 4, 2020
View reviewed changes
@sivaschenko
Copy link
Member

#1554 removed from description as it still should be handled for PNG

@sivaschenko
Copy link
Member

Integration tests have been extracted to a separate pull request to merge the prototype and address the infrastructure issue with integration tests separately

@sivaschenko
Copy link
Member

Integration tests in #1560

@sivaschenko
Copy link
Member

@magento run all tests

@sivaschenko
Copy link
Member

@magento run all tests

@sivaschenko sivaschenko merged commit 261458c into magento:2.0-develop Jul 4, 2020
@ghost
Copy link

ghost commented Jul 4, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivaschenko sivaschenko sivaschenko left review comments

Assignees

@sivaschenko sivaschenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create IPTC writer Create IPTC reader
2 participants
@Nazar65 @sivaschenko