Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polpulate asset metadata on uploading the image to magento && Populate media asset description when saving image from adobe stock #1596

Merged
merged 37 commits into from
Jul 26, 2020
Merged

Polpulate asset metadata on uploading the image to magento && Populate media asset description when saving image from adobe stock #1596

merged 37 commits into from
Jul 26, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jul 14, 2020 •
edited
Loading

Description (*)

Fixed Issues (if relevant)

  1. Fixes Polpulate asset metadata on uploading the image to magento #1497: Polpulate asset metadata on uploading the image to magento
  2. Fixes Populate media asset description when saving image from adobe stock #1495: Populate media asset description when saving image from adobe stock
  3. Newly added Description is removed after Media Gallery synchronization #1627

Manual testing scenarios (*)

Should be checked for the next scenarios:

  • Uploading the image to the enhanced media gallery
  • Uploading the image to the old media gallery
  • Uploading the image to the category
  • Uploading the image to the Page builder
  • Saving images from Adobe Stock
  • Runing bin/magento media-gallery:sync for images added manually to pub/media directory

@Nazar65
Polpulate asset metadata on uploading the image to magento &&
6a4ddd3 
Populate media asset description when saving image from adobe stock
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 15, 2020

@magento run all tests

@Nazar65 Nazar65 added the MFTF tests MFTF tests coverage label Jul 15, 2020
@Nazar65 Nazar65 mentioned this pull request Jul 15, 2020
Merged
4 tasks
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 15, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 15, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 15, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 15, 2020

@magenti run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 15, 2020

@magento run all tests

@gabrieldagama gabrieldagama self-assigned this Jul 16, 2020
gabrieldagama
gabrieldagama suggested changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nazar65, thanks for the pull request, it looks great! Please follow some comments below, let me know if you have any questions.

AdobeStockImage/Model/SaveMediaGalleryAsset.php Outdated Show resolved Hide resolved
MediaGalleryIntegration/Model/SaveImageKeywordsInformation.php Outdated Show resolved Hide resolved
MediaGalleryIntegration/Model/SaveImageKeywordsInformation.php Outdated Show resolved Hide resolved
MediaGalleryIntegration/Model/SaveImageKeywordsInformation.php Outdated Show resolved Hide resolved
MediaGalleryIntegration/Model/SaveImageKeywordsInformation.php Outdated Show resolved Hide resolved
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 21, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 21, 2020

@magento run all tests

@lenaorobei
Copy link
Contributor

@magento run Static Tests

sivaschenko
sivaschenko requested changes Jul 22, 2020
View reviewed changes
Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Nazar65 ! Please see my review comments

MediaGalleryIntegration/Plugin/SaveImageInformation.php Outdated Show resolved Hide resolved
MediaGalleryUi/composer.json Outdated Show resolved Hide resolved
@Nazar65 Nazar65 linked an issue Jul 22, 2020 that may be closed by this pull request
Newly added Description is removed after Media Gallery synchronization #1627
Closed
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 22, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 22, 2020

@magento run all tests

@sivaschenko
Copy link
Member

@magento run all tests

@chalov-anton
Copy link
Contributor

✔️ QA Passed

The locally uploaded jpeg image has Details, Description and Tags

@sivaschenko sivaschenko merged commit ca7210f into magento:2.0-develop Jul 26, 2020
@ghost
Copy link

ghost commented Jul 26, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama requested changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@gabrieldagama gabrieldagama

Labels
MFTF tests MFTF tests coverage Progress: done
Projects
None yet
Milestone
No milestone
5 participants
@Nazar65 @chalov-anton @sivaschenko @lenaorobei @gabrieldagama