MAGECLOUD-4264: Deliver patches for MSI

magento · Oct 9, 2019 · 343c25e · 343c25e
1 parent 6b8b33a
commit 343c25e
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/Step/Deploy/PreDeploy/ConfigUpdate/Cache.php b/src/Step/Deploy/PreDeploy/ConfigUpdate/Cache.php
@@ -67,7 +67,7 @@ public function execute()
 
         if (isset($cacheConfig['frontend'])) {
             $cacheConfig['frontend'] = array_filter($cacheConfig['frontend'], function ($cacheFrontend) {
-                return $cacheFrontend['backend'] != 'Cm_Cache_Backend_Redis'
+                return $cacheFrontend['backend'] !== 'Cm_Cache_Backend_Redis'
                     || $this->testRedisConnection($cacheFrontend['backend_options']);
             });
         }
@@ -94,15 +94,20 @@ public function execute()
      * @param array $backendOptions
      *
      * @return bool
+     * @throws StepException
      */
     private function testRedisConnection(array $backendOptions): bool
     {
-        if (!isset($backendOptions['server']) || !isset($backendOptions['port'])) {
+        if (!isset($backendOptions['server'], $backendOptions['port'])) {
             throw new StepException('Missing required Redis configuration!');
         }
 
         $sock = socket_create(AF_INET, SOCK_STREAM, SOL_TCP);
-        $connected = @socket_connect($sock, $backendOptions['server'], $backendOptions['port']);
+        $connected = @socket_connect(
+            $sock,
+            (string)$backendOptions['server'],
+            (int)$backendOptions['port']
+        );
         socket_close($sock);
 
         return $connected;