Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Refactor Magento\GraphQl\Quote\Customer\GetCustomerCartTest #1056

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Refactor Magento\GraphQl\Quote\Customer\GetCustomerCartTest #1056

merged 2 commits into from
Nov 14, 2019

Conversation

TomashKhamlai
Copy link
Contributor

@TomashKhamlai TomashKhamlai commented Nov 11, 2019 •
edited
Loading

Description (*)

Refactoring:

  • removed function for getting customer_token. (duplication)
  • removed assertion from private function revokeCustomerToken that is nod considered as a test and already covered with tests

Fixed Issues (if relevant)

  1. Tests from GetCustomerCartTest failed locally. Tests have assertions outside of testFunctions #1055: Tests from GetCustomerCartTest failed locally. Tests have assertions outside of testFunctions

Manual testing scenarios (*)

  1. Run tests for Quote module or just
  • testGetNewCustomerCart
  • testGetCustomerCartAfterTokenRevoked
  • testRequestCustomerCartTwice

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@TomashKhamlai
Refactoring:
cdbd452 
 - removed function for getting `customer_token`. (dublication)
 - removed assertion from private function revokeCustomerToken that is nod considered as test and already covered with tests

Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
@TomashKhamlai
Remove redundant variable assignment
3e80240 
Signed-off-by: Tomash Khamlai <tomash.khamlai@gmail.com>
magento-engcom-team pushed a commit that referenced this pull request Nov 14, 2019
@lenaorobei
ENGCOM-6270: Refactor Magento\GraphQl\Quote\Customer\GetCustomerCartT…
f7727e4 
…est #1056
@magento-engcom-team magento-engcom-team merged commit 3e80240 into magento:2.3-develop Nov 14, 2019
@ghost
Copy link

ghost commented Nov 14, 2019

Hi @TomashKhamlai, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@naydav naydav Awaiting requested review from naydav

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomashKhamlai @lenaorobei @magento-engcom-team