This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 154
[Checkout coverage] Added discount information to shopping cart #717
Merged
magento-engcom-team
merged 6 commits into
2.3-develop
from
683-add-discount-information-cart
Jun 19, 2019
Merged
[Checkout coverage] Added discount information to shopping cart #717
magento-engcom-team
merged 6 commits into
2.3-develop
from
683-add-discount-information-cart
Jun 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaorobei
previously approved these changes
May 29, 2019
Hi @lenaorobei, thank you for the review. |
@rogyar as per latest GraphQL sync upplease consider changing |
naydav
approved these changes
Jun 11, 2019
Hi @naydav, thank you for the review. |
- extracted discount cases to separate test class; - added case for no discount applied; - return `null` for discount node if amount is 0.
naydav
approved these changes
Jun 12, 2019
Hi @naydav, thank you for the review. |
naydav
added
Progress: accept
Auto-Tests: Covered
and removed
Progress: needs update
labels
Jun 12, 2019
Hi @rogyar, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Dec 5, 2019
- Reverted BIC actiongroup change - Changed actionGroup to extend existing - Moved test materials from incorrect modules back into correct module - added cleanup steps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR adds additional information about discount to the shopping cart details. The information contains discount amount and a label of the applied rule(s).
Fixed Issues (if relevant)
Manual testing scenarios (*)
or use cart query for an existing cart with a product and discount: