Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

url_path is not working as documented #721

Merged
merged 1 commit into from
Jun 19, 2019

Conversation

XxXgeoXxX
Copy link
Member

Description (*)

Original Issue #713

Fixed Issues (if relevant)

Fix based on magento/magento2#9113

But according to comment of sdzhepa
url_path is deprecated.

@naydav
Maybe the better solution is to remove this field from documentation and schema in graphql.
Could you clarify?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

- added `@deprecated` tag to the `url_path`
- details magento/magento2#9113
@magento-engcom-team
Copy link
Contributor

Hi @naydav, thank you for the review.
ENGCOM-5289 has been created to process this Pull Request
✳️ @naydav, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

Hi @naydav, thank you for the review.
ENGCOM-5289 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 7cc8c69 into magento:2.3-develop Jun 19, 2019
@ghost
Copy link

ghost commented Jun 19, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants