Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

magento/graphql-ce#985: Remove unnecessary exceptions #995

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Oct 9, 2019

Description (*)

This PR removes unnecessary exceptions in Magento\CustomerGraphQl\Model\Customer\CheckCustomerPassword.

Fixed Issues (if relevant)

  1. [Test coverage] Cover exceptions in CustomerGraphQl\Model\Customer\CheckCustomerPassword #985: [Test coverage] Cover exceptions in CustomerGraphQl\Model\Customer\CheckCustomerPassword

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6054 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ghost
Copy link

ghost commented Oct 13, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@lenaorobei lenaorobei deleted the 985-remove-unnecessary-exceptions branch October 14, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants