Terms and Conditions validation not working on payment method change

[magento2dev]

The default Magento_CheckoutAgreements module does not display error message for Terms and Condition checkbox even if it's not checked on payment change.

Preconditions

1. Use Magento 2.2.7

Steps to reproduce

1. Create a Terms and Conditions entry under Stores > Terms and Conditions and activate them under Stores > Sales > Checkout > Enable Terms and Conditions
2. Enable two payment method
3. On checkout payment step select a payment method
4. Click Place Order
5. Validation message for checkout agreements appears
6. Select a different payment method
7. Click Place Order
8. No error message is displayed even if you don't check the terms and conditions checkbox

Expected result

1. Error message should be displayed to warn the user he must agree the terms and conditions

Actual result

1. The order is placed

[m2-assistant]

Hi @magento2dev. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@magento2dev do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @AlexWorking. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.

  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

• 6. Add label Issue: Confirmed once verification is complete.

• 7. Make sure that automatic system confirms that report has been added to the backlog.

[AlexWorking]

Hello @magento2dev. We've been not able to reproduce Your issue on the latest develop version. Could You please try to reproduce Your issue on 2.3-develop version as You are asked above:

Thank You.

[magento2dev]

Hello @AlexWorking,

Thanks for your reply but as I mentionned the issue is tested on Magento 2.2 not on 2.3. I did not test on 2.3 because I don't want to switch version and many people still have the issue on 2.2 as you can see on closed issue #6224

Thanks for your help

[AlexWorking]

@magento2dev, unfortunately if the issue is not reproducible on a 2.3-develop version we consider it as fixed and do not provide fixes for earlier versions. (Please expound and look at the Details to the stage 4 of our recheck flow a bit above from here

). But it's quite possible that we miss something in the Steps to Reproduce You provided, or do something incorrectly, or probably You have forgotten to tell us some essential nuance. Therefore if You had a success in repproducing the issue on a develop instance You could help us to reproduce it ourselves and thus to confirm it. So maybe You will try? Thank You.

[m2-assistant]

Hi @krnshah. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.
  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[sdzhepa]

@magento give me 2.2-develop instance

[magento-engcom-team]

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.2-develop instance for you

[magento-engcom-team]

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-22992-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[sdzhepa]

Hello @magento2dev

I tried to reproduce this issue on the vanilla Magento instance based on 2.2-develop branch.
I used steps from this issue description and from closed #6224

And I cannot reproduce the issue have to close it as Cannot Reproduce resolution

But feel free to provide additional details/steps and reopen it.

I suppose it could be some specific and missed precondition(s) or step.
Or the issue is already fixed for the latest 2.2.x release.

Additional details and steps used to reproduce
Note: Tried to reproduce using Google Chrome and FireFox browsers

1. Install clear vanilla Magento instance based on 2.2-develop

2. Create test simple product and assign it to test category

3. Go to Stores > Terms and Conditions and create a new one with Applied = Manual
   --

4. Go to Stores > SALES > Payment Method and enable 2 payments, for test I used:
   -- Check / Money order
   -- Purchase Order

5. Enable Terms and Condition for Checkout in Stores > SALES > Checkout
   --

6. Save Config and Flush all Caches

7. Go to Storefront and add test product to the cart

8. Complete Shipping Checkout step and go to the payment

Actual Result Validation message appears I cannot place order