Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout Agreement validation is broken on payment method change #6224

Closed
shortner opened this issue Aug 18, 2016 · 10 comments
Closed

Checkout Agreement validation is broken on payment method change #6224

shortner opened this issue Aug 18, 2016 · 10 comments
Assignees
@victor-v-rad
Labels
bug report Component: Checkout Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@shortner
Copy link

Magento_CheckoutAgreements does not display validation message for Terms and Condition item after change of payment method.

Preconditions

  1. Install Magento 2.1

Steps to reproduce

  1. Create a Term and Condition entry under Stores > Terms and Conditions
  2. Activate Terms and Conditions for checkout under Stores > Sales > Checkout > Enable Terms and Conditions
  3. Enable a second payment method
  4. Go through checkout
  5. On Review & Payments step select a payment method
  6. Click Place Order
  7. Validation message for Term and Condition entry appears
  8. Select different payment method
  9. Click Place Order
  10. No validation message appears

Expected result

  1. Validation message for unaccepted Term and Condition entry appears

Actual result

  1. No validation message for unaccepted Term and Condition entry appears
@bka
Copy link
Contributor

bka commented Aug 18, 2016

Same issue here. Seems to be in Magento/CheckoutAgreements/view/frontend/web/js/model/agreement-validator.js, errorPlacement is only called once and places the label after the active checkbox. But every payment method has its own checkboxes.

@bka bka mentioned this issue Aug 18, 2016
Closed
@bka
Copy link
Contributor

bka commented Aug 18, 2016

This seems to solve the issue for me.

bka added a commit to bka/magento2 that referenced this issue Aug 25, 2016
@bka
fix for magento#6224: iterate over all agreement checkboxes in all pa…
6d172c9 
…yment methods to place error label
@victor-v-rad victor-v-rad self-assigned this Aug 26, 2016
@victor-v-rad victor-v-rad added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development 2.0.x labels Aug 26, 2016
@victor-v-rad
Copy link
Contributor

Internal issue MAGETWO-57682 was created to fix this

Bartlomiejsz pushed a commit to Bartlomiejsz/magento2 that referenced this issue Aug 30, 2016
Fix for magento#6224, uncheck other payments agreements before valida…
71f98a4 
…tion
@Bartlomiejsz Bartlomiejsz mentioned this issue Aug 30, 2016
Closed
mmansoor-magento pushed a commit that referenced this issue Oct 26, 2016
MAGETWO-57682: [GitHub] Checkout Agreement validation is broken on pa…
4d89955 
…yment method change #6224
mmansoor-magento pushed a commit that referenced this issue Oct 26, 2016
@slavvka
Merge pull request #535 from magento-folks/bugfix
bd1655b 
[Folks] Bugs:
- MAGETWO-59258 [Github] Override module-directory/etc/zip_codes.xml only the last code of a country gets included #6694
- MAGETWO-59512 [GitHub] Products in wishlist show $0.00 price #6866
- MAGETWO-59185 [GITHUB] Offline carrier configuration option "showmethod" does not appear in admin panel carrier configuration page #5693
- MAGETWO-59130 [Github] REST API with searchCriteria does not return category_ids #6127
- MAGETWO-57850 Unable to filter blocks using store view and block ID
- MAGETWO-57682 [GitHub] Checkout Agreement validation is broken on payment method change #6224
- MAGETWO-59573 Braintree JS error on checkout after applying 100% discount coupon with free shipping enabled
@SerhiyShkolyarenko
Copy link
Contributor

The fix is delivered to develop branch. Closing the issue.

@Ctucker9233
Copy link

@SerhiyShkolyarenko Will MAGETWO-57682 be included in 2.1.3?

@joni-jones joni-jones mentioned this issue Mar 24, 2017
Closed
magento-team pushed a commit that referenced this issue Sep 27, 2017
@svitja
MAGETWO-57683: [Backport] Checkout Agreement validation is broken on …
ffd3d76 
…payment method change #6224
@thoho-mpa
Copy link

Now the Checkout-Agreements does not work, I have a Magento 2.1.10 with Checkout-Agreements enabled (Manuel - with Checkbox).

I can Place the order without checking the Agreement.

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 11, 2018
@Rekha-periasamy
Copy link

I have upgraded to Magento 2.1.12. I have applied 6224. Still it's not working. I;m able to place order without choosing checkout agreements and it's doesn't show any validation message. I need a fix for this issue urgently. Kindly help

@david-fiaty-cko
Copy link

is there any progress on this bug? I am on Magento 2.2.5 and the issue is still there. The workarounds suggested above don't fix it.

@rdudhara
Copy link

rdudhara commented May 2, 2019

Is there any progress to fix into 2.1.9?

@magento2dev
Copy link

Does anyone has a fix I still have the issue on 2.2.3 and the fix above do not work ?

Thanks

@magento2dev magento2dev mentioned this issue May 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victor-v-rad victor-v-rad

Labels
bug report Component: Checkout Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests