Major 2.1.3 regression bug breaks js translations, caused by overly aggressive performance optimizations of the static content deployment #7862

hostep · 2016-12-17T19:54:00Z

Preconditions

Magento CE 2.1.3
PHP 7.0.14

Steps to reproduce

Install Magento CE 2.1.3 using composer
Install a couple of language packs (for example one for nl_NL and fr_FR)
Setup multiple storeviews, each one in a different language
Put your store in production mode (I used the --skip-compilation flag)
Run setup:static-content:deploy --theme=Magento/luma en_US nl_NL fr_FR
Go to each storeview in the frontend and go to the 'create an account' page
Don't fill in the fields, just press the 'Create an Account' button

Expected result

The warnings about the required fields are translated on each different storeview in its own language

Actual result

The warnings about the required fields on all different storeviews are all in English (the first language of the setup:static-content:deploy command)

Discussion

Magento 2.1.3 has optimized the static content deployment so it only generates the content for the first language and then blindly copies that directory to the other requested locales.
This is really great, because 99% of the files in those directories are always the same.
Except for the javascript translations...
And now we have this problem caused by this optimization.

More info

In Magento 2.1.2, if I take a diff of the nl_NL & fr_FR directories, I see 4 files which differ:

....pub/static/frontend/Vendor/theme $ diff -rwq nl_NL fr_FR
Files nl_NL/css/email-inline.css and fr_FR/css/email-inline.css differ
Files nl_NL/css/email.css and fr_FR/css/email.css differ
Files nl_NL/css/styles-m.css and fr_FR/css/styles-m.css differ
Files nl_NL/js-translation.json and fr_FR/js-translation.json differ

I'm not sure if the changes in the email css files are important, the changes in the styles-m.css files only differ by the order in which they are defined (which is weird, but whatever), but the most important file is that js-translation.json file.

Workaround

You can work around this bug by executing the setup:static-content:deploy command for every language separately:

php bin/magento setup:static-content:deploy --theme=Magento/luma en_US
php bin/magento setup:static-content:deploy --theme=Magento/luma nl_NL
php bin/magento setup:static-content:deploy --theme=Magento/luma fr_FR

But this means you can't depend on the performance optimization which runs these processes in parallel, which was introduced in 2.1.1.

@ Magento team: seriously, can you actually test stuff before releasing them into a new version? We aren't waiting on new "performance optimization" features, we just want bug fixes for now, not new features with new bugs.

@woosley-mg @benmarks: I expect this major bug the be resolved in maximum 2 weeks (or let's make it 3 due to the upcoming holidays). Thank you!

The text was updated successfully, but these errors were encountered:

Ctucker9233 · 2016-12-17T20:02:42Z

@hostep I think their testing procedures are broken. Just going by TravisCI, even pull requests always fail with the same error. I'm of the opinion that this error is hiding a lot of other major errors. @woosley-mg @benmarks can version 2.1.4 be completely clean please?

petterkj · 2016-12-20T09:08:10Z

2.1.3. Also happens in backend. Confirmed. I noticed this also. I had to disable static versioning in Admin Configuration Development, else "translations-nb.js" was not loading. I got the error when I tried to list products in admin - empty result and stops at loading spinner because the translation JS file was not found.

hostep · 2016-12-20T09:24:25Z

@petterkj: sorry, but your issue has nothing to do with what I describe above. In my case the js-translation.json file is getting created but contains the wrong translations.
Your issue is more related to this one I think: #7869

siraybit · 2016-12-21T12:25:50Z

Another issue with this optimization is that when you did all steps as it described in install guide, the js and css don't work. Magento 2.1.3 looking for it in some strange location for example http://magento2ce.loc/pub/static/version1482322390/adminhtml/Magento/backend/en_US/requirejs/require.js. Why it 'version1482322390' path is appeared in my url? I do not have it directory, so, js and css could not work.

hostep · 2016-12-21T12:38:07Z

@molneek: this again has nothing to do with what I describe above.

What you now experience is that Magento has switched the static signing of assets to on by default now.
See the release notes: http://devdocs.magento.com/guides/v2.1/release-notes/ReleaseNotes2.1.3CE.html:

Versioning of static files (including CSS, JS, font, and image files) is now enabled by default.

You can disable this in the backend under Advanced => Developer => Sign Static Files

siraybit · 2016-12-21T12:56:48Z

@hostep Thanks, but who can explain why it versioning was necessary enabled by default?
The

Versioning of static files (including CSS, JS, font, and image files) is now enabled by default.

is located in middle of release notes. After install new version I expect that all previous features work as well as before but every time I get new issues and should looking for solutions for fix this instead of do my work.

unfunco · 2016-12-22T09:51:04Z

@Ctucker9233 See tweet stream here: https://twitter.com/tonypiper/status/809328942968664064 – also, the semantic version was increased to say BC, but the notes said no BC. They have confirmed the bug (affecting Travis) is in test and not in M2 code, but you're right, it could be hiding all sorts of other nasties.

shiftedreality · 2016-12-26T09:24:00Z

Hi @hostep

Thanks for reporting.
We've created internal ticket MAGETWO-62660 to investigate and fix this issue.

dmrachkovskyi · 2016-12-27T11:05:06Z

Hi @hostep

We've added the bug and your workaround to Known Issues for both CE and EE Release Notes (Magento 2.1.3).

Thanks for your support!

philipvandebriel · 2017-01-10T12:53:58Z

I have same problem with 2.1.3 js-translations.

mvmenno · 2017-01-19T10:47:33Z

I am experiencing the same issues also on 2.0.11 when using: setup:static-content:deploy en_US fr_FR
(Single store mode)

philipvandebriel · 2017-01-19T11:03:04Z

@mvmenno

It's work if you do

setup:static-content:deploy en_US
and then
setup:static-content:deploy fr_FR

mvmenno · 2017-01-19T11:10:11Z

@phillipvandebriel ah i noticed this works. Well i am deploying using capistrano for multiple installations. So i have to write a new task for that, thank you!

redelschaap · 2017-01-27T07:51:02Z

The suggested workaround works indeed. However, I noticed the js-translation file also remain empty when requesting one language in combination with a specific theme or area. In other words, js-translation files also contain an empty string when using one the following commands (and probably commands with other extra parameters):

bin/magento setup:static-content:deploy nl_NL --area frontend
bin/magento setup:static-content:deploy nl_NL --area frontend --exclude-theme Magento/blank
bin/magento setup:static-content:deploy nl_NL --theme Magento/luma

Flamestyle · 2017-01-27T16:08:32Z

Same problem.
Server: Ubuntu 16.04, Nginx 1.10, PHP 7, MySQL 5.7, Magento 2.1.3 CE clear.
Command php /var/www/html/bin/magento setup:static-content:deploy --theme Magento/luma ru_RU don't help. I think Magento 2 will never work well. Throughout the year, I'm trying to run project on Magento 2. Every step - errors in Magento 2.

mvmenno · 2017-01-27T16:13:13Z

@ALL btw. if you only have 1 language for a site it also helps setting all admin users locale to the locale of the frontend store. That way you don't have to compile the en_US language ,it saves the hassle. Afterwards you deploy with static-content:deploy (language code)

hostep · 2017-01-27T18:36:01Z

@redelschaap are you sure? Because we run something like this when we deploy and it works perfectly fine:

bin/magento setup:static-content:deploy --theme Magento/backend en_US
bin/magento setup:static-content:deploy --theme Vendor/custom nl_NL
bin/magento setup:static-content:deploy --theme Vendor/custom fr_FR

(the area is not strictly necessary I believe, Magento is able to figure it out on its own)

Flamestyle · 2017-01-28T09:46:07Z

@hostep My steps:
Copy file ru_RU to theme, or create pack to app/i18n.

cd /var/www/agestor.ru/html
rm -rf pub/static/*
rm -rf var/view_preprocessed/*
bin/magento cache:clean
bin/magento setup:static-content:deploy --theme Magento/backend en_US
bin/magento setup:static-content:deploy --theme Agestor/default ru_RU
bin/magento cache:clean

Result: all js phrases on English (minicheckout, checkout).

hostep · 2017-01-28T12:19:12Z

@Flamestyle: sorry, you must be doing something wrong, because it works over here.

Install Magento CE 2.1.3 using composer
Install a Russian language pack using composer (I took this one: https://github.com/Magento2Translations/language_ru_ru)
Set your locale in the Magento backend to ru_RU
Run php bin/magento setup:static-content:deploy --theme Magento/luma ru_RU
Check the js-translation.json file:

$ head -c 100 pub/static/frontend/Magento/luma/ru_RU/js-translation.json
{"Close":"\u0417\u0430\u043a\u0440\u044b\u0442\u044c","Loading...":"\u0417\u0430\u0433\u0440\u0443\u

after cleaning up the escaped characters (just informational, the above should already work):

{"Close": "Закрыть", "Loading...": "Загрузка...",

Flamestyle · 2017-01-28T12:30:41Z

@hostep I don't using composer with Russian pack. Only add file ru_RU to theme. Or make my pack same official documentation.
You try Manually method?
js-translation.json - empty...
I can't use this pack - 26% ready.
Magento 2 have docs - this not works.
Please write steps, who can correct use translation with files (composer.json, language.hml, registration.php, xx_XX.csv) or only one file xx_XX in theme.

redelschaap · 2017-01-31T10:17:29Z

@hostep Yes I'm sure. Just tested this again. It only works for me when I delete the js-translation.json file manually and request one language without any other parameters.

Flamestyle · 2017-01-31T13:44:46Z

@hostep Please detail your steps.
I try 2 methods:
Method 1: Create a language package same official docs, create 4 files: composer.json, language.hml, registration.php, ru_RU.csv.
After make this commands:

cd /var/www/html
rm -rf pub/static/*
rm -rf var/view_preprocessed/*
php /var/www/html/bin/magento cache:clean
bin/magento setup:static-content:deploy --theme Magento/backend en_US
bin/magento setup:static-content:deploy --theme Agestor/default ru_RU
php /var/www/html/bin/magento cache:clean

Method 2: Add ru_RU to my theme. Path: app/design/frontend/Agestor/default/i18n/.
After make this commands:

cd /var/www/html
rm -rf pub/static/*
rm -rf var/view_preprocessed/*
php /var/www/html/bin/magento cache:clean
bin/magento setup:static-content:deploy --theme Magento/backend en_US
bin/magento setup:static-content:deploy --theme Agestor/default ru_RU
php /var/www/html/bin/magento cache:clean

Same problem: js phrases are not translated.

BenSpace48 · 2018-08-23T13:39:50Z

@magento-engcom-team - Any update on this please?

davemacaulay · 2018-08-23T14:47:41Z

@BenSpace48 I've checked the internal ticket and have seen some progress on this issue. I've chased again to get a better understanding on where this sits.

BenSpace48 · 2018-08-23T15:26:02Z

Thanks as always! <3

magento-engcom-team · 2018-12-18T14:51:33Z

Hi @TomashKhamlai. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

magento-engcom-team · 2019-01-09T09:43:07Z

Hi @engcom-backlog-tomash. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

magento-engcom-team · 2019-01-10T07:47:41Z

Hi @engcom-backlog-nazar. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

LiamKarlMitchell · 2019-02-22T05:07:44Z

Still a problem in 2.3 installed from composer create project can someone please give an example of what the contents of the js-translation.json file looks like as mine is just json []

hostep · 2019-02-22T08:34:17Z

@LiamKarlMitchell: I'm pretty sure you are running against another bug. This bug here is around the js-translation.json file containing data, but incorrect data (wrong translations).

Even though I'm like 99% sure this was fixed in Magento 2.2.2 and higher the labels added by @engcom-backlog-nazar seem to contradict this. Haven't tested it on 2.3 though...

benjamin-volle · 2019-05-21T07:32:58Z

I think I know this error and I solved it by the following patch :

--- a/vendor/magento/module-translation/Model/Json/PreProcessor.php
+++ b/vendor/magento/module-translation/Model/Json/PreProcessor.php
@@ -77,11 +77,12 @@ public function process(Chain $chain)
             if ($context instanceof FallbackContext) {
                 $themePath = $context->getThemePath();
                 $areaCode = $context->getAreaCode();
-                $this->translate->setLocale($context->getLocale());
             }
 
             $area = $this->areaList->getArea($areaCode);
             $area->load(\Magento\Framework\App\Area::PART_TRANSLATE);
+
+            $this->translate->setLocale($context->getLocale())->loadData($areaCode, true);
 
             $chain->setContent(json_encode($this->dataProvider->getData($themePath)));
             $chain->setContentType('json');

codercv · 2019-05-28T09:54:26Z

Thx man! You save my day :)

hostep · 2019-06-19T19:04:36Z

Closing as this was fixed somewhere in Magento 2.2.x

The only reason this ticket was still open is because it wasn't fixed yet in Magento 2.1
But Magento 2.1 will be EOL after its final release 2.1.18 next week, so let's just close this ticket.

…3 and through 2.2.2 or possible up to but not including 2.3.0 Indicator of being fixed in 2.2.2 and later: magento/magento2#10673 (comment) Indicator of it being fixed in 2.3.0 and later: magento/magento2#10913 Related to magento/magento2#7862 which is now closed as resolved in 2.2.x somewhere

hostep mentioned this issue Dec 19, 2016

Magento 2.1.0 Js Translations Not Working #7525

Closed

veloraven added 2.1.x bug report Component: Translation Component: Setup labels Dec 20, 2016

shiftedreality added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development develop labels Dec 26, 2016

ishakhsuvarov removed the Event: distributed-cd Distributed Contribution Day label Apr 13, 2018

magento-engcom-team added Event: distributed-cd Distributed Contribution Day and removed Event: distributed-cd Distributed Contribution Day Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Apr 13, 2018

sidolov removed the Performance label Aug 6, 2018

TomashKhamlai self-assigned this Dec 18, 2018

TomashKhamlai assigned ghost Jan 9, 2019

TomashKhamlai removed their assignment Jan 9, 2019

ghost assigned ghost and unassigned ghost Jan 10, 2019

ghost removed their assignment Jan 10, 2019

hostep closed this as completed Jun 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Major 2.1.3 regression bug breaks js translations, caused by overly aggressive performance optimizations of the static content deployment #7862

Major 2.1.3 regression bug breaks js translations, caused by overly aggressive performance optimizations of the static content deployment #7862

hostep commented Dec 17, 2016 •

edited

Loading

Ctucker9233 commented Dec 17, 2016

petterkj commented Dec 20, 2016 •

edited

Loading

hostep commented Dec 20, 2016

siraybit commented Dec 21, 2016

hostep commented Dec 21, 2016

siraybit commented Dec 21, 2016

unfunco commented Dec 22, 2016 •

edited

Loading

shiftedreality commented Dec 26, 2016

dmrachkovskyi commented Dec 27, 2016 •

edited

Loading

philipvandebriel commented Jan 10, 2017

mvmenno commented Jan 19, 2017 •

edited

Loading

philipvandebriel commented Jan 19, 2017

mvmenno commented Jan 19, 2017

redelschaap commented Jan 27, 2017

Flamestyle commented Jan 27, 2017 •

edited

Loading

mvmenno commented Jan 27, 2017

hostep commented Jan 27, 2017

Flamestyle commented Jan 28, 2017 •

edited

Loading

hostep commented Jan 28, 2017

Flamestyle commented Jan 28, 2017 •

edited

Loading

redelschaap commented Jan 31, 2017

Flamestyle commented Jan 31, 2017 •

edited

Loading

BenSpace48 commented Aug 23, 2018

davemacaulay commented Aug 23, 2018

BenSpace48 commented Aug 23, 2018

magento-engcom-team commented Dec 18, 2018

magento-engcom-team commented Jan 9, 2019

magento-engcom-team commented Jan 10, 2019 •

edited by bernarddelhez

Loading

LiamKarlMitchell commented Feb 22, 2019

hostep commented Feb 22, 2019

benjamin-volle commented May 21, 2019 •

edited

Loading

codercv commented May 28, 2019

hostep commented Jun 19, 2019

Major 2.1.3 regression bug breaks js translations, caused by overly aggressive performance optimizations of the static content deployment #7862

Major 2.1.3 regression bug breaks js translations, caused by overly aggressive performance optimizations of the static content deployment #7862

Comments

hostep commented Dec 17, 2016 • edited Loading

Preconditions

Steps to reproduce

Expected result

Actual result

Discussion

More info

Workaround

Ctucker9233 commented Dec 17, 2016

petterkj commented Dec 20, 2016 • edited Loading

hostep commented Dec 20, 2016

siraybit commented Dec 21, 2016

hostep commented Dec 21, 2016

siraybit commented Dec 21, 2016

unfunco commented Dec 22, 2016 • edited Loading

shiftedreality commented Dec 26, 2016

dmrachkovskyi commented Dec 27, 2016 • edited Loading

philipvandebriel commented Jan 10, 2017

mvmenno commented Jan 19, 2017 • edited Loading

philipvandebriel commented Jan 19, 2017

mvmenno commented Jan 19, 2017

redelschaap commented Jan 27, 2017

Flamestyle commented Jan 27, 2017 • edited Loading

mvmenno commented Jan 27, 2017

hostep commented Jan 27, 2017

Flamestyle commented Jan 28, 2017 • edited Loading

hostep commented Jan 28, 2017

Flamestyle commented Jan 28, 2017 • edited Loading

redelschaap commented Jan 31, 2017

Flamestyle commented Jan 31, 2017 • edited Loading

BenSpace48 commented Aug 23, 2018

davemacaulay commented Aug 23, 2018

BenSpace48 commented Aug 23, 2018

magento-engcom-team commented Dec 18, 2018

magento-engcom-team commented Jan 9, 2019

magento-engcom-team commented Jan 10, 2019 • edited by bernarddelhez Loading

LiamKarlMitchell commented Feb 22, 2019

hostep commented Feb 22, 2019

benjamin-volle commented May 21, 2019 • edited Loading

codercv commented May 28, 2019

hostep commented Jun 19, 2019

hostep commented Dec 17, 2016 •

edited

Loading

petterkj commented Dec 20, 2016 •

edited

Loading

unfunco commented Dec 22, 2016 •

edited

Loading

dmrachkovskyi commented Dec 27, 2016 •

edited

Loading

mvmenno commented Jan 19, 2017 •

edited

Loading

Flamestyle commented Jan 27, 2017 •

edited

Loading

Flamestyle commented Jan 28, 2017 •

edited

Loading

Flamestyle commented Jan 28, 2017 •

edited

Loading

Flamestyle commented Jan 31, 2017 •

edited

Loading

magento-engcom-team commented Jan 10, 2019 •

edited by bernarddelhez

Loading

benjamin-volle commented May 21, 2019 •

edited

Loading